Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

On Mon, 1 Oct 2007, Christoph Hellwig wrote:
> 
> befs_lookup, which the above gem is from, returns a dentry *.

Ahh, ok. Then it actually makes sense. Although I'd prefer it if people 
planned on writing code like that more along the lines of

	error = PTR_ERR(inode);
	if (IS_ERR(inode)
		return ERR_PTR(error);

because let's face it, the compiler can turn this into nice code, and 
humans can read it much better even if it's got an "unnecessary" extra 
variable etc..

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 00/30] Remove iget() and read_inode()
  - From: David Howells <[email protected]>
- [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
  - From: David Howells <[email protected]>
- Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
  - From: Zach Brown <[email protected]>
- Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
  - From: Linus Torvalds <[email protected]>
- Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
  - From: Christoph Hellwig <[email protected]>

Prev by Date: Re: F_DUPFD_CLOEXEC implementation
Next by Date: RE: Network slowdown due to CFS
Previous by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
Next by thread: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]