Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding

On 10/1/07, Akinobu Mita <[email protected]> wrote:
> 2007/10/2, Grant Likely <[email protected]>:
>
> >  static int __init
> >  xilinxfb_init(void)
> >  {
> > -       /*
> > -        * No kernel boot options used,
> > -        * so we just need to register the driver
> > -        */
> > +       int rc;
> > +       rc = xilinxfb_of_register();
> > +       if (rc)
> > +               return rc;
> > +
> >         return platform_driver_register(&xilinxfb_platform_driver);
>
> Is it better to add error handling for platform_driver_register()?

Right, good catch.  I'll fix that

Thanks!
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
[email protected]
(403) 399-0195
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/6] Patch series to add of_platform binding to xilinxfb
    • From: Grant Likely <[email protected]>
  • [PATCH 6/6] Xilinxfb: add of_platform bus binding
    • From: Grant Likely <[email protected]>
  • Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
    • From: "Akinobu Mita" <[email protected]>

• Prev by Date: Re: Fwd: x86_64 and AMD with C1E
• Next by Date: Re: [PATCH] [19/50] Experimental: detect if SVM is disabled by BIOS
• Previous by thread: Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
• Next by thread: Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]