Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding

2007/10/2, Grant Likely <[email protected]>:

>  static int __init
>  xilinxfb_init(void)
>  {
> -       /*
> -        * No kernel boot options used,
> -        * so we just need to register the driver
> -        */
> +       int rc;
> +       rc = xilinxfb_of_register();
> +       if (rc)
> +               return rc;
> +
>         return platform_driver_register(&xilinxfb_platform_driver);

Is it better to add error handling for platform_driver_register()?

    rc = platform_driver_register(&xilinxfb_platform_driver);
    if (rc)
        xilinxfb_of_unregister();

    return rc;


>  }
>
> @@ -398,6 +482,7 @@ static void __exit
>  xilinxfb_cleanup(void)
>  {
>         platform_driver_unregister(&xilinxfb_platform_driver);
> +       xilinxfb_of_unregister();
>  }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
    • From: "Grant Likely" <[email protected]>

• References:
  • [PATCH 0/6] Patch series to add of_platform binding to xilinxfb
    • From: Grant Likely <[email protected]>
  • [PATCH 6/6] Xilinxfb: add of_platform bus binding
    • From: Grant Likely <[email protected]>

• Prev by Date: Re: [PATCH 1/5] The config option itself
• Next by Date: Re: Fwd: x86_64 and AMD with C1E
• Previous by thread: [PATCH 6/6] Xilinxfb: add of_platform bus binding
• Next by thread: Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]