On Thu, 23 Aug 2007, Segher Boessenkool wrote: > > This simply isn't true. The compiler *can* combine asm stuff: Please Segher, just shut up. The combining, which I've mentioned *multiple*times* is if (atomic_read(&x) <= 1) and dammit, if that doesn't result in a *single* instruction, the code generation is pure and utter crap. It should result in cmpl $1,offset(reg) and nothing else. And there is no way in hell you are doing that with "atomic_read()" being inline asm. So can you now just go away? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- RE: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: "David Schwartz" <davids@webmaster.com>
- RE: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- References:
- [PATCH 0/23] make atomic_read() and atomic_set() behavior consistent across all architectures
- From: Chris Snook <csnook@redhat.com>
- [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Chris Snook <csnook@redhat.com>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Hirokazu Takata <takata@linux-m32r.org>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Hirokazu Takata <takata@linux-m32r.org>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Chris Snook <csnook@redhat.com>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Segher Boessenkool <segher@kernel.crashing.org>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Linus Torvalds <torvalds@linux-foundation.org>
- Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- From: Segher Boessenkool <segher@kernel.crashing.org>
- [PATCH 0/23] make atomic_read() and atomic_set() behavior consistent across all architectures
- Prev by Date: Re: gettimeofday() jumping into the future
- Next by Date: Re: Firewire lockup on 2.6.22.3 in SMP but not UP, old drivers
- Previous by thread: Re: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- Next by thread: RE: [PATCH 11/23] make atomic_read() and atomic_set() behavior consistent on m32r
- Index(es):
![]() |