Re: [PATCH] at91 pm: Compilation fix for at91sam926x

Am Donnerstag 09 August 2007 19:17 schrieb Andy Herzig:
> On Thu, 2007-08-09 at 18:01 +0200, Marc Pignat wrote:
> 
> > > > +#if defined(CONFIG_ARCH_AT91RM9200)
> > > >                         at91_sys_write(AT91_SDRAMC_SRR, 1);     /*
> > > > self-refresh mode */
> > Why don't use:
> > if (cpu_is_at91rm9200())
> > 	at91_sys_write(AT91_SDRAMC_SRR, 1);
> > 
> No reason. That looks good to me.

No, it doesn't look good. It won't compile.

Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] at91 pm: Compilation fix for at91sam926x
    • From: Andy Herzig <[email protected]>
  • Re: [PATCH] at91 pm: Compilation fix for at91sam926x
    • From: Marc Pignat <[email protected]>
  • Re: [PATCH] at91 pm: Compilation fix for at91sam926x
    • From: Andy Herzig <[email protected]>

• Prev by Date: Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets
• Next by Date: Re: [PATCH 1/24] make atomic_read() behave consistently on alpha
• Previous by thread: Re: [PATCH] at91 pm: Compilation fix for at91sam926x
• Next by thread: Re: [PATCH] at91 pm: Compilation fix for at91sam926x
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]