On Thu, 2007-08-09 at 18:01 +0200, Marc Pignat wrote:
> > > +#if defined(CONFIG_ARCH_AT91RM9200)
> > > at91_sys_write(AT91_SDRAMC_SRR, 1); /*
> > > self-refresh mode */
> Why don't use:
> if (cpu_is_at91rm9200())
> at91_sys_write(AT91_SDRAMC_SRR, 1);
>
No reason. That looks good to me.
> > > #ifdef CONFIG_PM
> > > +extern int at91_suspend_entering_slow_clock(void);
> Why do you define 3 times this function?
> Can't you place it in a .h?
I considered a .h, but I didn't see one that all drivers included. I
declare it in the 3 separate driver .c files that I saw needed it. There
is no pm.h and I didn't see the point in creating one just for that.
That of course will work if everyone likes that better. In either case,
you still have to add something to all three files.
-Andy H.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
