Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito

David Mosberger-Tang wrote:

This seems crazy to me.  Flushing should occur according to the
*architecture*, not model-by-model.  Even if we happen to get "lucky"
on pre-Montecito CPUs, that doesn't justify such ugly hacks.  Or you
really want to debug this *again* come next CPU?

  --david

O.K. let's say we flush by default: the global flag is set.

We can have a (short) list of the CPU models which do not require
this flush.

If all of the CPUs are on the list then clear the global flag. And:

static inline void sync_icache_dcache(pte_t pte) {
      if (pte_exec(pte) && global_flag)
              __sync_icache_dcache(pte);
}

Thanks,

Zoltan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
    • From: KAMEZAWA Hiroyuki <[email protected]>

• References:
  • [PATCH] flush icache before set_pte take6. [0/4]
    • From: KAMEZAWA Hiroyuki <[email protected]>
  • [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
    • From: KAMEZAWA Hiroyuki <[email protected]>
  • Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
    • From: "David Mosberger-Tang" <[email protected]>

• Prev by Date: Re: [ck] Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1)
• Next by Date: Re: [PATCH] usbhid: add ASUS LCM to the blacklist
• Previous by thread: Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
• Next by thread: Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]