Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch

Shaohua Li wrote:
>>
>>> 1. vmcs_readl/vmcs_writel are called with preempt enabled
>>>  
>>>       
>> Why is that bad?
>>     
> 1. raw_smp_processor_id()
> 2. migrate to other cpu
> 3. current->kvm_vcpu->cpu != the cpu id of step 1.
> you will see the warning.
>   

Ah, that code is gone from preempt-hooks, hence I didn't understand you.

The current version of the patchset does not change
vmcs_readl/vmcs_writel.  So I think everything is safe.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Shaohua Li <[email protected]>
  • Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Avi Kivity <[email protected]>
  • Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Shaohua Li <[email protected]>

• Prev by Date: Re: [kvm-devel] [RFC 0/8]KVM: swap out guest pages
• Next by Date: Re: [RFC/RFT 1/5] Input: implement proper locking in input core
• Previous by thread: Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
• Next by thread: [RFC 2/8]KVM: export several symbols kvm swap out needed
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]