Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch

On Mon, 2007-07-23 at 18:46 +0800, Avi Kivity wrote:
> Shaohua Li wrote:
> > fix some bugs in kvm-sch patch.
> >  
> 
> There is now a 'preempt-hooks' branch on kvm.git with the
> preempt-hooks
> work.  I'll continually update and rebase it against master.
> 
> > 1. vmcs_readl/vmcs_writel are called with preempt enabled
> >  
> 
> Why is that bad?
1. raw_smp_processor_id()
2. migrate to other cpu
3. current->kvm_vcpu->cpu != the cpu id of step 1.
you will see the warning.

Thanks,
Shaohua
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Avi Kivity <[email protected]>

• References:
  • [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Shaohua Li <[email protected]>
  • Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
    • From: Avi Kivity <[email protected]>

• Prev by Date: Re: [RFC 0/8]KVM: swap out guest pages
• Next by Date: Re: [PATCH 1/7] lguest: documentation pt I: Preparation
• Previous by thread: Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
• Next by thread: Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]