Re: [PATCH RFC] try_module_get usage

[Rusty Russell <rusty@rustcorp.com.au>]

On Wed, 2007-07-11 at 16:55 +0900, Fernando Luis Vázquez Cao wrote:
> I keep seeing uses of try_module_get(THIS_MODULE) which seem to mimic
> the behavior of the former MOD_INC_USE_COUNT. The UBI driver is one
> example:
> 
> int ubi_get_device_info(int ubi_num, struct ubi_device_info *di)
> {
>         const struct ubi_device *ubi;
> 
>         if (!try_module_get(THIS_MODULE))
>                 return -ENODEV;

Yes, this code is wrong.

Thanks,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/