Re: [patch] mm: recheck lock rlim after f_op->mmap() method

On Wed, Jul 11, 2007 at 02:12:45PM +0400, Dmitry Monakhov wrote:
> > > Or would this simpler patch be the right one?  I suspect the
> > > mspec driver only says VM_LOCKED because of a deep-seated but
> > > irrational fear that its pages might fall into reclaim.
> > 
> > Looks good.  We probably should add a debug check to do_mmap_pgoff
> > so that ->mmap methods don't change flags that are not for drivers.
> As result fglrx totally goes crazy, because it change vm_flags
> even from  ->nopage() calback :)

Well, everyone with half a brain knows that fglrx is not just legally
problematic but an utter piece of junk.  We should add more debug checks
to stop it from doing such stupid things.  And yes, chaning flags from
->nopage() does not just deserve a warning but a panic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] mm: recheck lock rlim after f_op->mmap() method
    • From: Hugh Dickins <[email protected]>

• References:
  • [patch] mm: recheck lock rlim after f_op->mmap() method
    • From: Dmitry Monakhov <[email protected]>
  • Re: [patch] mm: recheck lock rlim after f_op->mmap() method
    • From: Hugh Dickins <[email protected]>
  • Re: [patch] mm: recheck lock rlim after f_op->mmap() method
    • From: Christoph Hellwig <[email protected]>
  • Re: [patch] mm: recheck lock rlim after f_op->mmap() method
    • From: Dmitry Monakhov <[email protected]>

• Prev by Date: Re: [patch] mm: recheck lock rlim after f_op->mmap() method
• Next by Date: Re: [PATCH RFC] try_module_get usage
• Previous by thread: Re: [patch] mm: recheck lock rlim after f_op->mmap() method
• Next by thread: Re: [patch] mm: recheck lock rlim after f_op->mmap() method
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]