On Wed, 2007-06-27 at 19:45 +0200, Rodolfo Giometti wrote: > Ok. Please see the attached patch. Looks better. All I can find to complain about is the fact that you return whatever copy_from_user() returns. Don't -- that's the number of bytes left to copy. It should be if (copy_from_user(..)) return -EFAULT; -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- References:
- [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: David Woodhouse <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: David Woodhouse <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: David Woodhouse <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: David Woodhouse <[email protected]>
- Re: [PATCH] LinuxPPS (with new syscalls API)
- From: Rodolfo Giometti <[email protected]>
- [PATCH] LinuxPPS (with new syscalls API)
- Prev by Date: Re: [PATCH 16/16] fix handling of integer constant expressions
- Next by Date: Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c
- Previous by thread: Re: [PATCH] LinuxPPS (with new syscalls API)
- Next by thread: Re: [PATCH] LinuxPPS (with new syscalls API)
- Index(es):
 |