Re: [PATCH] LinuxPPS (with new syscalls API)

On Wed, Jun 27, 2007 at 06:49:48PM +0100, David Woodhouse wrote:
> 
> Looks better. All I can find to complain about is the fact that you
> return whatever copy_from_user() returns. Don't -- that's the number of
> bytes left to copy. It should be if (copy_from_user(..)) return -EFAULT;

Ok, I'll fix it.

Just last question: I still don't well understand where I should
declare the new compat_sys_time_pps_fetch() syscall... it's
automagically defined by the system when CONFIG_COMPAT is enabled? :-o

Thanks for your help,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    [email protected]
Linux Device Driver                             [email protected]
Embedded Systems                     		[email protected]
UNIX programming                     phone:     +39 349 2432127
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>

• References:
  • [PATCH] LinuxPPS (with new syscalls API)
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: Rodolfo Giometti <[email protected]>
  • Re: [PATCH] LinuxPPS (with new syscalls API)
    • From: David Woodhouse <[email protected]>

• Prev by Date: Re: ZERO_PAGE() vs. loadable modules in Redhat 4.4 i386 kernels ...
• Next by Date: Re: [AppArmor 00/44] AppArmor security module overview
• Previous by thread: Re: [PATCH] LinuxPPS (with new syscalls API)
• Next by thread: Re: [PATCH] LinuxPPS (with new syscalls API)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]