On Wed, 27 Jun 2007, Al Viro wrote: > > Eh... I'd say that my variant for offsetof() is simply better - it usually > directly turns into EXPR_VALUE, right in place, without rather convoluted > work. Aside of "should such cast be a constant integer expression"... Umm. But sparse is meant to parse C code. Which very much includes *other* projects. The kernel, for example, has its own offsetof. And yes, these days we use "__compiler_offsetof()", but we used to do #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) and I seriously doubt that the kernel is the only one doing things like that. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Al Viro <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Segher Boessenkool <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Al Viro <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Josh Triplett <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Al Viro <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Al Viro <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Neil Booth <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- From: Al Viro <[email protected]>
- Re: [PATCH 16/16] fix handling of integer constant expressions
- Prev by Date: Re: [PATCH] LinuxPPS (with new syscalls API)
- Next by Date: Re: [PATCH] LinuxPPS (with new syscalls API)
- Previous by thread: Re: [PATCH 16/16] fix handling of integer constant expressions
- Next by thread: Re: [PATCH 16/16] fix handling of integer constant expressions
- Index(es):
 |