Not at all. On an 8641 it could be
compatible = "fsl,mpc8641-rapidio" "fsl,mpc8548-rapidio";
which states "this is the 8641 thing and it is compatible
to the 8548 thing". Perfectly clear.
The concern is this isn't just compatible = "..8641.." "..8548.." but
something like:
"..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.." "..8543e.."
"..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.."
You don't need to mention _all_ compatible devices in
the "compatible" property, only the few that matter;
typically the oldest one, and sometimes some intermediate
device that has extra features over the original one.
It isn't useful to add "compatible" entries that no OS
probes for.
Concrete names are good.
While I agree concrete names are good, we put these 'blocks' in so
many devices that using the device to match on is pointless.
You *definitely* should put the device name for _this_
device in there, in case it needs some special workaround.
I'm all for making up a name like 'Grande', 'Del', 'Janeiro'. This is
effective what we did with gianfar. The name gets picked up pretty
quickly by people.
That can be used as the "base" name, yes.
Segher
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
