Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

On Wed, 30 May 2007 16:42:41 -0700, Roland Dreier <[email protected]> wrote:

> If I just see
> 
> 	for (pos = list_entry((head)->next, typeof(*pos), member),
> 		n = list_entry(pos->member.next, typeof(*pos), member);
> 	     &pos->member != (head);
> 	     pos = n, n = list_entry(n->member.next, typeof(*n), member))
> 
> then what am I to think?

You won't catch me writing this kind of crap, so the question is moot.
Seriously, a comma operator? Admit it, you just expanded a marcro from
list.h by hand. Real people cannot write like that.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Roland Dreier <[email protected]>

• References:
  • [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Matthias Kaehlcke <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: "Satyam Sharma" <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Roland Dreier <[email protected]>

• Prev by Date: Re: [PATCH} x86_64 PM_TRACE support.
• Next by Date: Re: BUG: sleeping function called from invalid context at kernel/fork.c:385
• Previous by thread: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Next by thread: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]