Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

On Wed, 30 May 2007 10:47:52 +0200, Matthias Kaehlcke <[email protected]> wrote:

> @@ -1608,8 +1605,7 @@ static void ub_reset_task(struct work_struct *work)
>  	spin_lock_irqsave(sc->lock, flags);
>  	sc->reset = 0;
>  	tasklet_schedule(&sc->tasklet);
> -	list_for_each(p, &sc->luns) {
> -		lun = list_entry(p, struct ub_lun, link);
> +	list_for_each_entry(lun, &sc->luns, link) {
>  		blk_start_queue(lun->disk->queue);
>  	}
>  	wake_up(&sc->reset_wait);

This patch straddles the border of acceptable. The pointless obfuscation
is balanced against the removal of explicit type in list_entry() and thus
a possible mismatched struct. I'm not acking nor naking this.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: "Satyam Sharma" <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Matthias Kaehlcke <[email protected]>

• References:
  • [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Matthias Kaehlcke <[email protected]>

• Prev by Date: Re: [BUG sparc64] 2.6.22-rc broke X on Ultra5
• Next by Date: [PATCH 01/06] Use menuconfig objects 4 - ISDN part 1/6 (CONFIG_ISDN)
• Previous by thread: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Next by thread: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]