Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

 > The negative is the sheer number of helper functions in list.h. Personally,
 > I find it difficult to retain a working knowledge of them. Iterators are
 > particularly nasty that way. I'm thinking about dropping all of these
 > list_for_each_with_murky_argument_requirements_and_odd_side_effects()
 > and use plain for(;;), as a courtesy to someone who has to read the
 > code years down the road.

I think I disagree with this reasoning.  If I'm reading your code and
I see, say, list_for_each_entry_safe(), I can be pretty confident that
your loop works correctly.  If you write your own for loop, then I
have to check that you actually got the linked list walking right.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>

• References:
  • [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Matthias Kaehlcke <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: "Satyam Sharma" <[email protected]>
  • Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
    • From: Pete Zaitcev <[email protected]>

• Prev by Date: Re: GFP_DMA32 and PAE x86 machines
• Next by Date: Re: tty-related oops in latest kernel(s)?
• Previous by thread: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Next by thread: Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]