Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings

Jeremy Fitzhardinge wrote:

Eric W. Biederman wrote:

The only way to ensure this will not happen is to do what we do
on x86_64 and map the new page table page into our address space
before we write to it.  Assuming the page we allocate is already
mapped is simply not robust.

So you mean make alloc_bootmem make sure there's a mapping for the
returned page?  That would be simple enough, though it might interact
strangely with the actual construction of the memory mappings (what if
the page alloc_bootmem just allocated for the pagetable is the page
pagetable_init is actually trying to map?).

I'm not sure about the issue with holes.  I assume you mean that just
because head.S maps a chunk of memory, it isn't necessarily available
for allocation because its a hole.  But does alloc_bootmem know to avoid
them anyway?  Has it already parsed e820 at that point?

Since we allocate the maximum possible memory statically, I fail to see how holes could make the situation any worse, or better.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [PATCH 00/28] Updates for firstfloor paravirt-ops patches
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Chuck Ebbert <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: Re: BUG: Null pointer dereference (2.6.21-rc7)
• Next by Date: Re: [PATCH] dma_declare_coherent_memory wrong allocation
• Previous by thread: Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
• Next by thread: Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]