H. Peter Anvin wrote: > Since we allocate the maximum possible memory statically, I fail to > see how holes could make the situation any worse, or better. No, we map enough space to map 4G (~4 pages), but we don't actually map 4G. If a hole happened to start within that 4 page mapping, then the memory still wouldn't be available for allocation. I think this is a bit of a spurious argument though, since if it were really a problem we'd have to worry about holes hitting the kernel image too. As far as I can see, that's not considered to be a problem. I think the real point is that there's currently a subtle dependency between head.S and bootmem allocation which happens between start_kernel and pagetable_init. Your patch preventing over-mapping should make them easier to smoke out as it currently stands, but eliminating the problem by making alloc_bootmem create the mappings for itself does have appeal. There would still be the dependency on head.S to map the kernel itself and the bootmem allocator bitmap. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: "H. Peter Anvin" <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- References:
- [PATCH 00/28] Updates for firstfloor paravirt-ops patches
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: Andi Kleen <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: "H. Peter Anvin" <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: Andi Kleen <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: "H. Peter Anvin" <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: Chuck Ebbert <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: Jeremy Fitzhardinge <[email protected]>
- Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- From: "H. Peter Anvin" <[email protected]>
- [PATCH 00/28] Updates for firstfloor paravirt-ops patches
- Prev by Date: Re: [PATCH] kthread: Spontaneous exit support
- Next by Date: serial8250 lockdep report from 2.6.21-rc7
- Previous by thread: Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- Next by thread: Re: [PATCH 10/28] i386: map enough initial memory to create lowmem mappings
- Index(es):