On Wed, Apr 11, 2007 at 12:52:56PM -0700, Zach Brown wrote:
> I'm worried that virtual aliasing spells doom for the current
> home-brewed serialization that fs/aio.c is doing with the shared ring
> head/tail accesses. Am I worrying about nothing here?
Adding a flush_dcache_page() should fix that, but it might also need a
change in the layout of the ring buffer header to get things completely
correct. What I'm thinking of is that the head and tail bits might need
to be on different cachelines to ensure any aliasing that does occur will
not result in updates colliding. I'm not that much of an expert on virtually
aliased caches, though.
> > > I will look into this aside from this patch.
> >
> > That's probably the case. Also, any changes in this area *must* correctly
> > update the compat/incompat feature flags in the ring buffer header. That
> > has been missed in the past...
>
> Do you know of anyone using the current ring info ABI?
>
> The *only* user I know of is the check of ctx->magic in libaio.
But... any libaio implementing the new sematics must be able to run on old
kernels by falling back to the syscall when it notices that required bits
aren't set in the header. It's easy enough to implement the checks, they
just need to be carefully checked before being shipped.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <[email protected]>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
