On Wed, Apr 11, 2007 at 12:28:26PM -0700, Ken Chen wrote:
> >I have mixed feelings. I think the userspace getevents support was
> >poorly designed and the simple fact that we've gone this long without it
> >says just how desperately the feature isn't needed.
>
> I kept on getting requests from application developers who want that
> feature. My initial patch was dated back May 2004.
The right way to do it involves synchronization between the kernel side
io_getevents() and the userspace code pulling events out of the ring.
Alan Cox suggested embedding a futex in the shared memory region, but I
don't think anyone ever implemented that.
> I noticed that while writing the patch. We have the same bug right
> now that nr_events is enlarged to consume the entire mmap'ed ring
> buffer pages. But yet, we don't account those in aio_max_nr. I
> didn't fix that up in this patch because I was going to do a separate
> patch on that.
It's not accounted because it is irrelevant -- the memory used by the
events is already accounted against the user's address space. The actual
number of aios in flight is clamped to the maximum number of requests
that was specified and accounted against the global reservation. The
number of events in the ringbuffer can be larger, and that doesn't hurt
anything.
> >The ring page, which is mmaped to userspace at some weird address, was
> >just written through a kmap. Do we need a flush_dcache_page()? This
> >isn't this patch's problem, but it'd need to be addressed if we're using
> >the ring from userspace.
>
> I will look into this aside from this patch.
That's probably the case. Also, any changes in this area *must* correctly
update the compat/incompat feature flags in the ring buffer header. That
has been missed in the past...
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <[email protected]>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
