Christoph wrote:
> If this is hidden in a macro then it may be overlooked.
Sooner or later, every line of code is important.
Shouting any one of them in #ifdef brackets creates
a noisier environment, increasing the chance of missing
another.
And besides ... the other umpteen cpuset hooks all use the
cpuset_*() style macros (except for fs/proc/base.c, which
has its own style ...).
Consistency in style is important in these matters.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- 2.6.20-rc4-mm1
- From: Andrew Morton <[email protected]>
- 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Sander <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Christoph Lameter <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Christoph Lameter <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <[email protected]>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Christoph Lameter <[email protected]>
- 2.6.20-rc4-mm1
- Prev by Date: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race
- Next by Date: Re: Disk Cache, Was: O_DIRECT question
- Previous by thread: Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- Next by thread: Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- Index(es):
 |