On Fri, 12 Jan 2007, Paul Jackson wrote: > Argh - minor detail, but this is the first (outside of fs/proc/base.c) > "#ifdef CONFIG_CPUSETS" in a kernel *.c file. I prefer to avoid that. Sorry but there will be number of those once we get the dirty writeback for cpusets fixed. Did you review that patchset (only internally mailed so far). I do not think it makes much sense to do these macros for the single occurrence here and otherwise. Having the #ifdef here is much clearer. Also the #ifdef is in already NUMA specific code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <pj@sgi.com>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- References:
- 2.6.20-rc4-mm1
- From: Andrew Morton <akpm@osdl.org>
- 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Sander <sander@humilis.net>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <pj@sgi.com>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Christoph Lameter <clameter@sgi.com>
- Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- From: Paul Jackson <pj@sgi.com>
- 2.6.20-rc4-mm1
- Prev by Date: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race
- Next by Date: Re: Linux Software RAID 5 Performance Optimizations: 2.6.19.1: (211MB/s read & 195MB/s write)
- Previous by thread: Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- Next by thread: Re: 'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)
- Index(es):
![]() |