Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().

On Sun, 3 Dec 2006, Alan wrote:

> >  	if (!p) {
> > -		p = kmalloc(sizeof(*p), GFP_KERNEL);
> > +		p = kzalloc(sizeof(*p), GFP_KERNEL);
> >  		if (!p)
> >  			return -ENOMEM;
> >  		file->private_data = p;
> >  	}
> > -	memset(p, 0, sizeof(*p));
> >  	mutex_init(&p->lock);
> >  	p->op = op;
>
>
> NAK
>
> If p was already set (ie private data existed) the old code zeroed it,
> your code does not, but only zeroes the new stuff.

whoops, sorry, my bad.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
    • From: "Robert P. J. Day" <[email protected]>
  • Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
    • From: Alan <[email protected]>

• Prev by Date: [PATCH] mm: Remove worthless comment referring to kzalloc_node().
• Next by Date: [PATCH] ieee1394: raw1394: don't save irq flags in interrupt-enabled sections
• Previous by thread: Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
• Next by thread: Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]