Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().

>  	if (!p) {
> -		p = kmalloc(sizeof(*p), GFP_KERNEL);
> +		p = kzalloc(sizeof(*p), GFP_KERNEL);
>  		if (!p)
>  			return -ENOMEM;
>  		file->private_data = p;
>  	}
> -	memset(p, 0, sizeof(*p));
>  	mutex_init(&p->lock);
>  	p->op = op;


NAK

If p was already set (ie private data existed) the old code zeroed it,
your code does not, but only zeroes the new stuff.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
    • From: "Robert P. J. Day" <[email protected]>

• References:
  • [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
    • From: "Robert P. J. Day" <[email protected]>

• Prev by Date: Re: [PATCH v2 02/13] Device Discovery and ULLD Linkage
• Next by Date: 2.6.19: kobject_add failed with -EEXIST
• Previous by thread: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
• Next by thread: Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]