Robert P. J. Day wrote:
> Convert all obvious combinations of kmalloc()+memset() to single
> kzalloc() in the fs/ directory.
[snip]
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index 555b9ac..f85feba 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -31,12 +31,11 @@ int seq_open(struct file *file, struct s
> struct seq_file *p = file->private_data;
>
> if (!p) {
> - p = kmalloc(sizeof(*p), GFP_KERNEL);
> + p = kzalloc(sizeof(*p), GFP_KERNEL);
> if (!p)
> return -ENOMEM;
> file->private_data = p;
> }
> - memset(p, 0, sizeof(*p));
> mutex_init(&p->lock);
> p->op = op;
It's not the same! Previous erases it every time seq_open is called and after
your change only once -- when p == NULL.
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
