Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

 > You would need to also cast the constants with typeof() to.

Why?  I'm not much of a C language lawyer, but I would have thought
that in something like

	(x) + _a - 1

the "1" will be promoted to the type of the rest of the expression
without any explicit cast.  I tested the unsigned long/unsigned int
and u64/int cases of ALIGN(), and my macro with typeof() works for
both of those cases at least.

 > But yes, given the array sizing case in the neighbour code,
 > perhaps we can use your original patch for now.  Feel free
 > to push that to Linus.

akpm is CC'ed on this thread.  Andrew, are you going to pick this up?

Thanks,
  Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Andrew Morton <[email protected]>

References:
- [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: David Miller <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: Roland Dreier <[email protected]>
- Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
  - From: David Miller <[email protected]>

Prev by Date: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Next by Date: Re: 2.6.19-rc5-mm2 (end earlier): WARNING at lib/kobject.c:172 kobject_init() on resume from disk
Previous by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Next by thread: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]