Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set

On Mon, 16 Oct 2006 10:00:25 +1000 Paul Mackerras <[email protected]> wrote:

> Andrew Morton writes:
> 
> > If the drivers doesn't care and if it makes no difference to performance
> > then just delete the call to pci_set_mwi().
> > 
> > But if MWI _does_ make a difference to performance then we should tell
> > someone that it isn't working rather than silently misbehaving?
> 
> That sounds like we need a printk inside pci_set_mwi then, rather than
> adding a printk to every single caller.
> 

I think so, yes.  That's a good solution to a lot of these things.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Matthew Wilcox <[email protected]>
  • Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Matthew Wilcox <[email protected]>
  • Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Matthew Wilcox <[email protected]>
  • Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: David Brownell <[email protected]>
  • Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Alan Cox <[email protected]>
  • Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Matthew Wilcox <[email protected]>
  • Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Andrew Morton <[email protected]>
  • Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
    • From: Paul Mackerras <[email protected]>

• Prev by Date: Re: [PATCH 1/4] l2cap endianness annotations
• Next by Date: Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
• Previous by thread: Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
• Next by thread: Re: [Bulk] Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]