Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal

Ar Sad, 2006-10-14 am 13:09 +0530, ysgrifennodd Amol Lad:
> On Fri, 2006-10-13 at 16:00 +0100, Alan Cox wrote:
> > Ar Gwe, 2006-10-13 am 17:10 +0530, ysgrifennodd Amol Lad:
> > > Removed save_flags()/cli()/sti() and used (light weight) spin locks
> > > 
> > 
> > Have you tested this and verified there are no recursive locking cases
> > in your changes ?
> 
> I doxygend riscom8.c and used call graphs to verify there are no
> recursive locks. I did a code review also

Thanks for the info. I'll give the code a second review (also not having
hardware) and then send you/Andrew either an Ack or corrections.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
  - From: Amol Lad <[email protected]>
- Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
  - From: Alan Cox <[email protected]>
- Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
  - From: Amol Lad <[email protected]>

Prev by Date: ppc prep boot hang in 2.6.19-rc2
Next by Date: Re: + convert-cpu-hotplug-notifiers-to-use-raw_notifier-instead-of-blocking_notifier.patch added to -mm tree
Previous by thread: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
Next by thread: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]