Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal

Ar Gwe, 2006-10-13 am 17:10 +0530, ysgrifennodd Amol Lad:
> Removed save_flags()/cli()/sti() and used (light weight) spin locks
> 

Three things I see that look problematic

1. The irq locking isn't doing anything as the IRQ handler itself is not
taking the lock
2. If the irq handler itself dumbly locks to fix this then we get
tty_flip_buffer_push() re-entering the other code paths and deadlocking
if low latency is enabled
3. Some of the use of local_save/spin_lock_irq seems over-clever and
unneeded

Fixable but how about we just delete the file since it has been broken
for ages and nobody can be using it ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
    • From: Amol Lad <[email protected]>
  • Re: [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
    • From: Matthew Wilcox <[email protected]>

• References:
  • [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
    • From: Amol Lad <[email protected]>

• Prev by Date: Re: [v4l-dvb-maintainer] 2.6.19-rc1: DVB frontend selection causes compile errors
• Next by Date: Re: [PATCH 1/2] [PCI] Check that MWI bit really did get set
• Previous by thread: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
• Next by thread: Re: [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]