Re: misused local_irq_disable() in analog.c?

On Wed, 11 Oct 2006 16:17:33 -0400 Dmitry Torokhov wrote:

> On 10/11/06, Alexey Dobriyan <[email protected]> wrote:
> > Dmitry, take a look at analog_cooked_read():
> >
> > do-while loop there contains local_irq_disable()/local_irq_restore(flags);
> > which aren't complement.
> >
> > Should it be
> >
> >    local_irq_save(flags);
> >    this = gameport_read(gameport) & port->mask;
> >    GET_TIME(now);
> >    local_irq_restore(flags);
> >
> > ?
> 
> Yep, I think so. Patch?

Alexey replied on another thread (Re: [PATCH] misuse of strstr):

"sorry for absence of patch, I'm on wonders of BY dial-up _and_ Gmail
web interface right now."


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • misused local_irq_disable() in analog.c?
    • From: "Alexey Dobriyan" <[email protected]>
  • Re: misused local_irq_disable() in analog.c?
    • From: "Dmitry Torokhov" <[email protected]>

• Prev by Date: Re: most users of msleep_interruptible are broken
• Next by Date: Re: [PATCH] use %p for pointers
• Previous by thread: Re: misused local_irq_disable() in analog.c?
• Next by thread: Kernel panic in 2.6.19-rc1
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]