misused local_irq_disable() in analog.c?

Dmitry, take a look at analog_cooked_read():

do-while loop there contains local_irq_disable()/local_irq_restore(flags);
which aren't complement.

Should it be

   local_irq_save(flags);
   this = gameport_read(gameport) & port->mask;
   GET_TIME(now);
   local_irq_restore(flags);

?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: misused local_irq_disable() in analog.c?
    • From: "Dmitry Torokhov" <[email protected]>

• Prev by Date: Re: [PATCH 2.6.18-mm2] acpi: add backlight support to the sony_acpi driver
• Next by Date: Re: [RFC] Avoid PIT SMP lockups
• Previous by thread: GRIO in Linux XFS?
• Next by thread: Re: misused local_irq_disable() in analog.c?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]