Re: misused local_irq_disable() in analog.c?

On 10/11/06, Alexey Dobriyan <[email protected]> wrote:

Dmitry, take a look at analog_cooked_read():

do-while loop there contains local_irq_disable()/local_irq_restore(flags);
which aren't complement.

Should it be

   local_irq_save(flags);
   this = gameport_read(gameport) & port->mask;
   GET_TIME(now);
   local_irq_restore(flags);

?


Yep, I think so. Patch?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: misused local_irq_disable() in analog.c?
  - From: Randy Dunlap <[email protected]>

References:
- misused local_irq_disable() in analog.c?
  - From: "Alexey Dobriyan" <[email protected]>

Prev by Date: [PATCH] null dereference in fs/jbd2/journal.c
Next by Date: Re: Dropping NETIF_F_SG since no checksum feature.
Previous by thread: misused local_irq_disable() in analog.c?
Next by thread: Re: misused local_irq_disable() in analog.c?
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]