Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value

On Mon, Oct 09, 2006 at 08:55:26PM +0900, Akinobu Mita wrote:
> 
> I misunderstood about crypto_alloc_tfm().
> 
> BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm().
> Should we mark it as __deprecated?

Probably.  Although anybody using crypto_alloc_tfm will probably
also use the old crypto interface which gives plenty of warnings
already.

> - __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure.
>   But it returns NULL.
> 
> - crypto_alloc_base() may not return -EINTR on signal_pending()
> 
> I'll fix the patch and resend with more clear description later.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    • From: [email protected] (Akinobu Mita)
  • Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    • From: Herbert Xu <[email protected]>
  • Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    • From: Akinobu Mita <[email protected]>

• Prev by Date: Re: md deadlock (was Re: 2.6.18-mm2)
• Next by Date: Why is device_create_file __must_check?
• Previous by thread: Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
• Next by thread: [PATCH] driver core: kmalloc() failure check
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]