Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value

On Mon, Oct 09, 2006 at 05:58:12PM +0900, Akinobu Mita wrote:
> crypto_alloc_tfm() and crypto_alloc_base() are suppose to return error code
> as pointer on failures. But there are some cases where they return NULL
> (for example, crypto_alloc_tfm() returns NULL on kzalloc() failure)
> 
> This patch fixes that wrong return value, and also fixes tcrypt so that it can
> detect error code correctly.

Actually, crypto_alloc_tfm is an obsolete function which is supposed
to maintain its previous semantics of returning NULL or success.

I don't quite see where the problem with crypto_alloc_base is.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    • From: Akinobu Mita <[email protected]>

• References:
  • [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
    • From: [email protected] (Akinobu Mita)

• Prev by Date: [PATCH] Driver core: Don't ignore bus_attach_device() retval
• Next by Date: Re: [patch 3/3] mm: fault handler to replace nopage and populate
• Previous by thread: [PATCH 2/2] crypto: delete duplicated code
• Next by thread: Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]