On 09/11, Dipankar Sarma wrote:
>
> On Sun, Sep 10, 2006 at 08:18:10PM +0400, Oleg Nesterov wrote:
> > On top of rcu-simplify-improve-batch-tuning.patch
> >
> > Cleanup. Move '#ifdef CONFIG_SMP' check and rdp->bhlimit setting
> > into force_quiescent_state().
>
>
> Pushing the rdp->blimit setting into force_quiescent_state is fine,
> but I see no need to insert #ifdef CONFIG_SMP into a routine.
Otherwise we need to push the rdp->blimit setting into both versions
of force_quiescent_state(), for CONFIG_SMP and !CONFIG_SMP.
> Let us continue to have separate versions of force_quiescent_state()
> for CONFIG_SMP and !CONFIG_SMP. It looks cleaner with #ifdefs inserted
> in between.
I personally think exactly opposite :)
Ok, let's forget about this patch, it was only cleanup.
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
