Re: [PATCH] force_quiescent_state: factor out duplicated code

On Sun, Sep 10, 2006 at 08:18:10PM +0400, Oleg Nesterov wrote:
> On top of rcu-simplify-improve-batch-tuning.patch
> 
> Cleanup. Move '#ifdef CONFIG_SMP' check and rdp->bhlimit setting
> into force_quiescent_state().

Pushing the rdp->blimit setting into force_quiescent_state is fine,
but I see no need to insert #ifdef CONFIG_SMP into a routine.
Let us continue to have separate versions of force_quiescent_state()
for CONFIG_SMP and !CONFIG_SMP. It looks cleaner with #ifdefs inserted
in between.

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] force_quiescent_state: factor out duplicated code
  - From: Oleg Nesterov <[email protected]>

References:
- [PATCH] force_quiescent_state: factor out duplicated code
  - From: Oleg Nesterov <[email protected]>

Prev by Date: Re: rcu_do_batch: rcu_data->qlen is not irq safe
Next by Date: Re: [PATCH] force_quiescent_state: factor out duplicated code
Previous by thread: [PATCH] force_quiescent_state: factor out duplicated code
Next by thread: Re: [PATCH] force_quiescent_state: factor out duplicated code
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]