On Sun, Sep 10, 2006 at 07:08:20PM +0400, Oleg Nesterov wrote:
> rcu_do_batch() decrements rdp->qlen with irqs enabled.
> This is not good, it can also be modified by call_rcu()
> from interrupt.
>
> So, is it worth fixing? The problem is mostly theoretical.
I think we should fix it even though the problem is theoritical.
> If yes, is it ok to use local_t ? Iirc, the were some
> problems with local_t on some arches. Sometimes it is
> just atomic_t ...
AFAIK, x86 local_t is atomic. Not good.
>
> Otherwise, we can update ->qlen after the main loop,
>
> local_irq_disable();
> rdp->qlen -= count;
> local_irq_enable();
>
> What dou you think?
We should do this.
Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
