Re: [PATCH 08/12] hdaps: Add explicit hardware configuration functions

["Shem Multinymous" <multinymous@gmail.com>]

On 8/8/06, Pavel Machek <pavel@suse.cz> wrote:

> >  static int needs_calibration = 0;
> Unneccessary initializer.

OK, though I would prefer to differentiate "initial value is 0" from
"initial value doesn't matter".


> > + * hdaps_set_fake_data_mode - enable or disable EC test mode, which fakes
> > + * accelerometer data using an incrementing counter.
> > + * Returns zero on success and negative error code on failure.  Can sleep.
> > + */
>
> Why do we want to have fake mode? I see it is useful for debugging,
> but?

It's useful for debugging userspace too. Apps like the hdapsd daemon
can use it to figure out how often and how regularly they get fresh
readouts, and whether they often miss readouts.


> > +/*
> > + * hdaps_check_ec - checks something about the EC.
> > + * Follows the clean-room spec for HDAPS; we don't know what it means.
> > + * Returns zero on success and negative error code on failure.  Can sleep.
> > + */
>
> URL for spec?

http://www.almaden.ibm.com/cs/people/marksmith/tpaps.html, it's at the
top of the original file.


> What happens when we delete this one?

No idea, nor a way to check (on all relevant models). We've always
done it, this patch just does it a bit more explicitly and by
correctly following the H8S LPC protocol.

OK on all other comments to patches 06-08.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/