Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

"Antonino A. Daplas" <[email protected]> writes:

> Eventually, I'm the one who's going to maintain the code, most
> of the drivers in the video directory are practically abandoned. 

BTW, it's fortunate that you are maintaing it. The I2C code in cirrusfb
uses vga_wseq() and vga_rseq(). Is it safe WRT races between I2C
adapter code and fb code? I don't see any locking here, and both
functions are non-atomic (write merging and posting will not break it,
but it looks like I need a lock for concurent access).
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>

• References:
  • [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: Krzysztof Halasa <[email protected]>
  • Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
    • From: "Antonino A. Daplas" <[email protected]>

• Prev by Date: Re: [PATCH] Clean up old names in tty code to current names
• Next by Date: Re: [PATCH 7/8] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #4]
• Previous by thread: Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
• Next by thread: Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]