Re: [patch] sharpsl_pm refactor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2006-07-07 at 13:48 +0200, Pavel Machek wrote:
> This prepares sharpsl_pm.c for collie. Without nested if()s, #ifdefs
> can be added. 

I'm unconvinced as to why collie needs an ifdef in there and looking at
what I think you're leading to, its ugly. Perhaps you could change the 2
to a variable set by the machine instead or something, depending upon
your intention.

Rather than post these patches straight to the patch system, perhaps you
could also post them for discussion first as discussing them once
they're submitted seems wrong (and we have to remember to remove the
patch system from the cc).

> Also warn users about charging in unsuitable
> temperature.

I'm ok with that bit.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux