Re: [PATCH] x86 built-in command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Followup to:  <[email protected]>
By author:    Matt Mackall <[email protected]nic.com>
In newsgroup: linux.dev.kernel
>
> This patch allows building in a kernel command line on x86 as is
> possible on several other arches.
> 
> Index: linux/arch/i386/kernel/setup.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/setup.c	2006-05-26 16:18:13.000000000 -0500
> +++ linux/arch/i386/kernel/setup.c	2006-06-11 16:23:51.000000000 -0500
> @@ -713,6 +713,10 @@ static void __init parse_cmdline_early (
>  	int len = 0;
>  	int userdef = 0;
>  
> +#ifdef CONFIG_CMDLINE_BOOL
> +	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#endif
> +
>  	/* Save unparsed command line copy for /proc/cmdline */
>  	saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
>  

NAK.

a. Please make the patch available for x86-64 as well as x86.  The two
are coupled enough that they need to agree.

b. This patch will override a user-provided command line if one
exists.  This is the wrong behaviour; instead, the builtin command
line should only apply if no user-specified command line is present.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux