Re: [PATCH] HPT3xx: switch to using pci_get_slot()

Hello.

Jiri Slaby wrote:

  Switch to using pci_get_slot() to get to the function 1 of HPT36x/374
chips -- there's no need for the driver itself to walk the list of the
PCI devices, and it also forgets to check the bus number of the device
found.

It's better, but you missed to call pci_dev_put() in some __exit function.

If you knew the PCI IDE drivers better, you'd know there's simply no __exit functions in them. ;-)

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH][RFT] HPT3xxN clocking fixes
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH] Fix the case of multiple HPT3xx chips present
    • From: Sergei Shtylyov <[email protected]>
  • Re: [PATCH] HPT3xx: fix PCI clock detection
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH] HPT3xx: rework rate filtering
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH] HPT3xx: print the real chip name at startup
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH] HPT3xx: switch to using pci_find_slot()
    • From: Sergei Shtylyov <[email protected]>
  • [PATCH] HPT3xx: switch to using pci_get_slot()
    • From: Sergei Shtylyov <[email protected]>
  • Re: [PATCH] HPT3xx: switch to using pci_get_slot()
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: Asus K8N-VM Motherboard Ethernet Problem
• Next by Date: [PATCH] mm/comments: kmalloc man page before 2.6.17 (the fifth attempt)
• Previous by thread: Re: [PATCH] HPT3xx: switch to using pci_get_slot()
• Next by thread: Re: [PATCH] HPT37x: read f_CNT saved by BIOS from port
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]