Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead

[Ian Kent <raven@themaw.net>]

On Mon, 22 May 2006, Christoph Hellwig wrote:

> On Mon, May 22, 2006 at 02:35:19AM -0700, Andrew Morton wrote:
> > The loop driver plays with file_operations.write() also.  The code should
> > be reviewed and tested against filesystems which use LO_FLAGS_USE_AOPS as
> > well as against those which do not, please.
> 
> The LO_FLAGS_USE_AOPS stuff is broken, please drop it from -mm.  I
> explained to the RedHAt guy in detail on how to get it right.
> 
> That beeing said the bu isn't autofs using ->write directly which is
> done in a lot of places but the pipe code not setting it to
> do_sync_write.
> 

If there's anything I need to do to help just point me in the right 
direction.

The brief look at the patch that I had left me thinking the read and write 
methods were not set but I probably missed something obvious and didn't 
return to look again.

Ian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/