On Mon, 22 May 2006, Christoph Hellwig wrote: > On Mon, May 22, 2006 at 02:35:19AM -0700, Andrew Morton wrote: > > The loop driver plays with file_operations.write() also. The code should > > be reviewed and tested against filesystems which use LO_FLAGS_USE_AOPS as > > well as against those which do not, please. > > The LO_FLAGS_USE_AOPS stuff is broken, please drop it from -mm. I > explained to the RedHAt guy in detail on how to get it right. > > That beeing said the bu isn't autofs using ->write directly which is > done in a lot of places but the pipe code not setting it to > do_sync_write. > If there's anything I need to do to help just point me in the right direction. The brief look at the patch that I had left me thinking the read and write methods were not set but I probably missed something obvious and didn't return to look again. Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops.
- From: Badari Pulavarty <[email protected]>
- [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops.
- From: Badari Pulavarty <[email protected]>
- [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO
- From: Badari Pulavarty <[email protected]>
- [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO
- From: Badari Pulavarty <[email protected]>
- [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Badari Pulavarty <[email protected]>
- Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Andrew Morton <[email protected]>
- Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Christoph Hellwig <[email protected]>
- Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Andrew Morton <[email protected]>
- Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Andrew Morton <[email protected]>
- Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- From: Christoph Hellwig <[email protected]>
- [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops.
- Prev by Date: RE: replacing X Window System !
- Next by Date: Re: [IDEA] Poor man's UPS
- Previous by thread: Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- Next by thread: Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead
- Index(es):
 |