Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)

On Wed, 26 Apr 2006, Kyle Moffett wrote:
> Here's code that I've found works as well as can be expected under both GCC 3
> and GCC 4.  If xp is a known-NULL constant the whole function will be
> optimized out completely.  If xp is known-not-NULL, then it will optimize to a
> kfree function without the null check.  Otherwise it optimizes to call the
> out-of-line version.

Wouldn't it be better to simply remove calls to kfree() with known 
NULL constant?

				Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Nick Piggin <[email protected]>

• References:
  • [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Hua Zhong <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: "Pekka Enberg" <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Pekka J Enberg <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Jörn Engel <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Pekka J Enberg <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Jörn Engel <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Bart Hartgers <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Bart Hartgers <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Kyle Moffett <[email protected]>

• Prev by Date: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Next by Date: O_DIRECT, ext3fs, kernel 2.4.32... again
• Previous by thread: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Next by thread: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]