Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)

["Pekka Enberg" <penberg@cs.helsinki.fi>]

On 4/25/06, Hua Zhong <hzhong@gmail.com> wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index e6ef9bd..0fbc854 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3380,7 +3380,7 @@ void kfree(const void *objp)
>         struct kmem_cache *c;
>         unsigned long flags;
>
> -       if (unlikely(!objp))
> +       if (!objp)
>                 return;

NAK. Fix the callers instead.

                                              Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/