Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)

On 4/25/06, Hua Zhong <[email protected]> wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index e6ef9bd..0fbc854 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3380,7 +3380,7 @@ void kfree(const void *objp)
>         struct kmem_cache *c;
>         unsigned long flags;
>
> -       if (unlikely(!objp))
> +       if (!objp)
>                 return;

NAK. Fix the callers instead.

                                              Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Arjan van de Ven <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Andreas Mohr <[email protected]>

• References:
  • [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Hua Zhong <[email protected]>

• Prev by Date: Re: [patch 3/3] use kref for bio
• Next by Date: Re: [patch 3/3] use kref for bio
• Previous by thread: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Next by thread: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]