Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)

On Wed, 2006-04-26 at 10:30 +0300, Pekka Enberg wrote:
> On 4/25/06, Hua Zhong <[email protected]> wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > index e6ef9bd..0fbc854 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -3380,7 +3380,7 @@ void kfree(const void *objp)
> >         struct kmem_cache *c;
> >         unsigned long flags;
> >
> > -       if (unlikely(!objp))
> > +       if (!objp)
> >                 return;
> 
> NAK. Fix the callers instead.

eh dude... they are being fixed... to remove the NULL check :)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Pekka J Enberg <[email protected]>

• References:
  • [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: Hua Zhong <[email protected]>
  • Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
    • From: "Pekka Enberg" <[email protected]>

• Prev by Date: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Next by Date: [PATCH] kprobe: boost 2byte-opcodes on i386
• Previous by thread: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Next by thread: Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]