Re: [PATCH 2/3] swsusp i386 mark special saveable/unsaveable pages

[Nigel Cunningham <ncunningham@cyclades.com>]

Hi.

On Wednesday 19 April 2006 11:22, Shaohua Li wrote:
> On Wed, 2006-04-19 at 08:38 +1000, Nigel Cunningham wrote:
> > Hi.
> >
> > On Wednesday 12 April 2006 12:38, Shaohua Li wrote:
> > > @@ -1400,6 +1401,111 @@ static void set_mca_bus(int x)
> > >  static void set_mca_bus(int x) { }
> > >  #endif
> > >
> > > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > > +static void __init mark_nosave_page_range(unsigned long start,
> > > unsigned long end) +{
> > > +	struct page *page;
> > > +	while (start <= end) {
> >
> > Should this be start < end? (End is usually the first byte of the next
> > zone IIUC).
>
> Thanks for looking at it. Yes you are right. Before calling this
> routine, I already decrement 1 for 'end', so the routine will have the
> last page pfn.

Ah. I see. In the call itself. Sneaky :)

Would you consider modifying that bit so it doesn't confuse others in the 
future?

Oh, and while we're on the topic, if only part of a page is NVS, what's the 
right behaviour? My e820 table has:

BIOS-e820: 000000003dff0000 - 000000003dffffc0 (ACPI data)
BIOS-e820: 000000003dffffc0 - 000000003e000000 (ACPI NVS)

Regards,

Nigel

Attachment: pgpkQahq8nt17.pgp
Description: PGP signature