Re: [PATCH 2/3] swsusp i386 mark special saveable/unsaveable pages

[Shaohua Li <shaohua.li@intel.com>]

On Wed, 2006-04-19 at 08:38 +1000, Nigel Cunningham wrote:
> Hi.
> 
> On Wednesday 12 April 2006 12:38, Shaohua Li wrote:
> > @@ -1400,6 +1401,111 @@ static void set_mca_bus(int x)
> >  static void set_mca_bus(int x) { }
> >  #endif
> >
> > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > +static void __init mark_nosave_page_range(unsigned long start, unsigned
> > long end) +{
> > +	struct page *page;
> > +	while (start <= end) {
> 
> Should this be start < end? (End is usually the first byte of the next zone 
> IIUC).
Thanks for looking at it. Yes you are right. Before calling this
routine, I already decrement 1 for 'end', so the routine will have the
last page pfn.

Thanks,
Shaohua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/